1.x: NotificationLite - reduce allocations #4621
Merged
+194
−284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of commonly used operators allocated an instance of
NotificationLite
as a field in a subscriber but for no great type-safety benefit. I've cut these fields by converting all instance methods ofNotificationLite
to static methods and removing theNotificationLite.instance()
method.The changes are trivial till you get to the
Subjects
that would pass instances ofNotificationLite
in methods of theSubjectSubscriptionManager
. Still simple changes but reviewing these is a good idea.RxJava2 goes a bit further in the internals of
NotificationLite
. I'd like to leave changes to the internals beyond making methods static for another PR if appropriate.