1.x: SafeSubscriber not to call RxJavaHooks before delivering the original error. #4641
+24
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the introduction of
RxJavaHooks
, theSafeSubscriber._onError
called the original error handler with the exception it received which was by default an empty handler. The defaultRxJavaHooks.onError
behavior, however is to signal errors to the uncaught exception handler of the caller thread which leads to unnecessary logging or app crashes even though the error itself is to be handled properly.This PR restores the
SafeSubscriber._onError
to skip theRxJavaHooks
and call the original handler directy so old tracking code should still get all safe error while newer hooking doesn't get called.Related: #4332.