Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: SafeSubscriber not to call RxJavaHooks before delivering the original error. #4641

Merged
merged 1 commit into from
Sep 30, 2016

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Sep 29, 2016

Before the introduction of RxJavaHooks, the SafeSubscriber._onError called the original error handler with the exception it received which was by default an empty handler. The default RxJavaHooks.onError behavior, however is to signal errors to the uncaught exception handler of the caller thread which leads to unnecessary logging or app crashes even though the error itself is to be handled properly.

This PR restores the SafeSubscriber._onError to skip the RxJavaHooks and call the original handler directy so old tracking code should still get all safe error while newer hooking doesn't get called.

Related: #4332.

@codecov-io
Copy link

Current coverage is 84.56% (diff: 100%)

Merging #4641 into 1.x will increase coverage by 0.08%

@@                1.x      #4641   diff @@
==========================================
  Files           274        274          
  Lines         17766      17766          
  Methods           0          0          
  Messages          0          0          
  Branches       2727       2727          
==========================================
+ Hits          15009      15024    +15   
+ Misses         1889       1878    -11   
+ Partials        868        864     -4   

Powered by Codecov. Last update 2b47efe...d66196a

@akarnokd
Copy link
Member Author

/cc @dlew

@dlew
Copy link

dlew commented Sep 30, 2016

LGTM. Thanks for doing this.

@akarnokd akarnokd merged commit 09b1389 into ReactiveX:1.x Sep 30, 2016
@akarnokd akarnokd deleted the SafeSubscriberNoHookCall branch September 30, 2016 18:39
@akarnokd akarnokd mentioned this pull request Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants