1.x: fix subscribe(Action1 [, Action1]) to report isUnsubscribed

[akarnokd]

The lambda version didn't report isUnsubscribed() as before because of the removal of the SafeSubscriber wrapping. This PR makes sure it reports consistently again.

Repored in: #4715

Note that there is no unsafeSubscribe(SingleSubscriber) so a regular subscribe(SingleSubscriber) by default won't report isUnsubscribed() == true unless the implementation of onSuccess and onError - controlled by the user - doesn't call unsubscribe on itself.

[codecov-io]

Current coverage is 84.09% (diff: 100%)

Merging #4716 into 1.x will increase coverage by <.01%

@@                1.x      #4716   diff @@
==========================================
  Files           288        288          
  Lines         17986      17987     +1   
  Methods           0          0          
  Messages          0          0          
  Branches       2746       2745     -1   
==========================================
+ Hits          15125      15127     +2   
- Misses         1981       1983     +2   
+ Partials        880        877     -3   

Powered by Codecov. Last update 1ac5834...bdbd69f

[marwinxxii]

Hi everyone,

Seems like subscribe(SingleSubscriber) overload has the same problem, because Single.just(1).subscribe(new SingleSubscriber<Integer>(){...}).isUnsubscribed() returns false.

I checked version 1.2.2-SNAPSHOT. In 1.2.0 it returns true as expected.

[akarnokd]

@marwinxxii Single has no notion of SafeSingleSubscriber and the internals got changed to improve performance. Therefore, you are responsible calling unsubscribe in your implementation of onSuccess and onCompleted.

[marwinxxii]

Sorry, I missed this part in PR description.

May be this should be added to SingleSubscriber documentation (or may be Single.subscribe(SingleSubscriber)?

[akarnokd]

PR welcome to change the docs.

[marwinxxii]

Done - #4769