Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.x: Add null check to Observable.switchIfEmpty #4791

Merged
merged 2 commits into from
Nov 1, 2016
Merged

1.x: Add null check to Observable.switchIfEmpty #4791

merged 2 commits into from
Nov 1, 2016
+10 −0

Conversation

ortex
Copy link

@ortex ortex commented Oct 31, 2016

@codecov-io
Copy link

codecov-io commented Oct 31, 2016 •
edited
Loading

Current coverage is 83.94% (diff: 100%)

Merging #4791 into 1.x will decrease coverage by 0.05%

@@                1.x      #4791   diff @@
==========================================
  Files           286        286          
  Lines         17752      17754     +2   
  Methods           0          0          
  Messages          0          0          
  Branches       2701       2702     +1   
==========================================
- Hits          14911      14903     -8   
- Misses         1972       1975     +3   
- Partials        869        876     +7

Powered by Codecov. Last update 5747017...9888936

JakeWharton
JakeWharton approved these changes Oct 31, 2016
View reviewed changes
Copy link
Contributor

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be lovely

@akarnokd akarnokd added the Bug label Oct 31, 2016
@akarnokd akarnokd added this to the 1.3 milestone Oct 31, 2016
akarnokd
akarnokd requested changes Oct 31, 2016
View reviewed changes
Copy link
Member

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test.

@akarnokd akarnokd merged commit c65b3db into ReactiveX:1.x Nov 1, 2016
@akarnokd akarnokd mentioned this pull request Nov 1, 2016
Closed
@ortex ortex deleted the add-null-check-to-switch-if-empty branch November 1, 2016 14:38
@akarnokd akarnokd mentioned this pull request Nov 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton

@akarnokd akarnokd

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ortex @codecov-io @JakeWharton @akarnokd