Schedule when bug fix #4826
Merged
Schedule when bug fix #4826
+224
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k to get unsubscribed too early. Changed the code to delay the calling of onCompleted of the CompletableSubscriber until the actualAction is truly done.
akarnokd
approved these changes
Nov 9, 2016
| static final Subscription UNSUBSCRIBED = Subscriptions.unsubscribed(); | ||
|
|
||
| @SuppressWarnings("serial") | ||
| private static abstract class ScheduledAction extends AtomicReference<Subscription>implements Subscription { |
There was a problem hiding this comment.
private creates extra accessors in an Android unfriendly way. Could you change these into package-private?
There was a problem hiding this comment.
Do you want the changes to package-private in a new PR? For both 1.x and 2.x?
Current coverage is 84.19% (diff: 87.83%)@@ 1.x #4826 diff @@
==========================================
Files 287 287
Lines 17828 17835 +7
Methods 0 0
Messages 0 0
Branches 2702 2702
==========================================
+ Hits 14983 15016 +33
+ Misses 1968 1953 -15
+ Partials 877 866 -11
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In using this in production we found a bug where some actions were dropped. I've tracked it down to the premature onCompleted and unsubscription of the completable that represents the scheduled action causes the future to get canceled before it is started.
The fix was to delay the onCompleted until the action was truly done.
I did the PR as two commits because the first one is changing all the tabs to spaces! Look at the second commit for the actual functional difference.