1.x: Completable.doAfterTerminate to run after onError as well #4830
+14
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.13% (diff: 71.42%)@@ 1.x #4830 diff @@
==========================================
Files 287 287
Lines 17852 17856 +4
Methods 0 0
Messages 0 0
Branches 2704 2704
==========================================
+ Hits 15021 15024 +3
+ Misses 1964 1963 -1
- Partials 867 869 +2
|
JakeWharton
approved these changes
Nov 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DoAfterTerminate was intended to call the callback after either onCompleted or onError but somehow missed that behavior in 1.x.
Related: #4822