1.x: remove ObjectPool, code style cleanups #4846
Merged
+607
−1,065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.16% (diff: 66.00%)@@ 1.x #4846 diff @@
==========================================
Files 287 285 -2
Lines 17868 17763 -105
Methods 0 0
Messages 0 0
Branches 2706 2691 -15
==========================================
- Hits 15036 14951 -85
+ Misses 1970 1954 -16
+ Partials 862 858 -4
|
JakeWharton
reviewed
Nov 14, 2016
| this.pool = pool; | ||
| this.queue = pool.borrowObject(); | ||
| private RxRingBuffer(boolean spmc, int size) { | ||
| this.queue = spmc ? new SpmcArrayQueue<Object>(size) : new SpscArrayQueue<Object>(size); | ||
| this.size = size; | ||
| } | ||
|
|
||
| public synchronized void release() { // NOPMD |
There was a problem hiding this comment.
Thought about it but it's a semi-public API and I didn't want to break it just that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
ObjectPoolandSynchronizedQueueas their utility now seems surpassed.In addition, this PR contains a bunch of code style cleanups. Use the
?w=1parameter to hide whitespace changes.Other changes:
BackpressureOverflowrx.io-scheduler.keepaliveSchedulersjavadoc