1.x: fix Completable.concat & merge hanging in async situations #4849
+132
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.28% (diff: 91.66%)@@ 1.x #4849 diff @@
==========================================
Files 285 285
Lines 17763 17765 +2
Methods 0 0
Messages 0 0
Branches 2691 2691
==========================================
+ Hits 14947 14974 +27
+ Misses 1956 1938 -18
+ Partials 860 853 -7
|
JakeWharton
approved these changes
Nov 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the hang in
Completable.concat(Observable)andCompletable.merge(Observable)mainly due to usingsubscribeinstead ofunsafeSubscribe. The underlying problem was thatSafeSubscriberunsubscribed the dowstream consumer which cancelled the outstanding elements ofrange.In addition, I've upgraded the
concat(Observable)to use an up-to-date concatenation algorithm and more compact memory footprint.