Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: Single::takeUntil CancellationException message enh. #4852

Merged
merged 1 commit into from
Nov 15, 2016

Conversation

akarnokd
Copy link
Member

This PR modifies the CancellationException message to include the operator name and source type.

Relate: #4756

@codecov-io
Copy link

Current coverage is 84.27% (diff: 100%)

Merging #4852 into 1.x will increase coverage by 0.07%

@@                1.x      #4852   diff @@
==========================================
  Files           285        285          
  Lines         17765      17765          
  Methods           0          0          
  Messages          0          0          
  Branches       2691       2691          
==========================================
+ Hits          14957      14971    +14   
+ Misses         1953       1939    -14   
  Partials        855        855          

Powered by Codecov. Last update 745a922...8812756

Copy link
Contributor

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this, but it's better than adding a new public exception type.

@akarnokd akarnokd merged commit 7fb3987 into ReactiveX:1.x Nov 15, 2016
@akarnokd akarnokd deleted the SingleTakeUntilMessage branch November 15, 2016 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants