-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add which are the other stardard methods of create #5000
Conversation
@@ -63,7 +63,7 @@ protected Observable(OnSubscribe<T> f) { | |||
|
|||
/** | |||
* <strong>This method requires advanced knowledge about building operators and data sources; please consider | |||
* other standard methods first;</strong> | |||
* other standard methods first, as {@link Observable#fromEmitter(Action1, Emitter.BackpressureMode)};</strong> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
such as
I accept this change but developers should really spend time discovering the methods of RxJava for themselves. Otherwise we'd have 30k lines in |
Current coverage is 84.20% (diff: 100%)@@ 1.x #5000 diff @@
==========================================
Files 288 288
Lines 17806 17806
Methods 0 0
Messages 0 0
Branches 2698 2698
==========================================
- Hits 15007 14994 -13
- Misses 1950 1956 +6
- Partials 849 856 +7
|
Updated. I understand your concerns about the lenght of this file. But there's too much noise on internet about this method: posts, tutorials, gists... |
The reactivex.io docs group operators by category, including a "Creating
Observables" <http://reactivex.io/documentation/operators.html#categorized>
category. This may help you if you're trying to find just the right
operator to initiate an Observable.
…On Tue, Jan 17, 2017 at 4:36 AM, David Karnok ***@***.***> wrote:
Merged #5000 <#5000>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5000 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AESHoOjpc8-Vdip48vBXpIHPVtopFtMpks5rTLW_gaJpZM4Lldk1>
.
--
David M. Gross
PLP Consulting
|
I know... and this is all the information that I can find there:
Nothing about |
I was using
Observable.create(OnSubscribe)
. I knew about the warning:But I didn't know which were the other stadard methods. There were no clue in the JavaDoc. With this change the problem is gone.