1.x: fix groupBy consuming the upstream in an unbounded manner #5030
+35
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.14% (diff: 100%)@@ 1.x #5030 diff @@
==========================================
Files 288 288
Lines 17806 17805 -1
Methods 0 0
Messages 0 0
Branches 2698 2698
==========================================
- Hits 14993 14982 -11
- Misses 1958 1965 +7
- Partials 855 858 +3
|
artem-zinnatullin
approved these changes
Jan 28, 2017
JakeWharton
approved these changes
Jan 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an unnecessary
request(1),groupByconsumed the upstream in an unbounded manner no matter the downstream request patterns against the main or the inner groups themselves.This PR fixes this by removing it and rearranging the group/group item handling similar to how 2.x is implemented.
Related #5029.