Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: add unsubscribeOn to Single type (#5138) #5146

Merged
merged 1 commit into from
Mar 12, 2017

Conversation

yshrsmz
Copy link

@yshrsmz yshrsmz commented Feb 28, 2017

resolve #5138

add unsubscribeOn to Single type.

@codecov
Copy link

codecov bot commented Feb 28, 2017

Codecov Report

Merging #5146 into 1.x will increase coverage by 0.07%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                1.x    #5146      +/-   ##
============================================
+ Coverage     84.29%   84.37%   +0.07%     
- Complexity     2875     2878       +3     
============================================
  Files           290      290              
  Lines         18091    18107      +16     
  Branches       2475     2475              
============================================
+ Hits          15250    15277      +27     
+ Misses         1973     1960      -13     
- Partials        868      870       +2
Impacted Files Coverage Δ Complexity Δ
src/main/java/rx/Single.java 73.86% <100%> (+3.29%) 82 <1> (+1)
...in/java/rx/internal/schedulers/SleepingAction.java 55.55% <0%> (-5.56%) 2% <0%> (-1%)
.../java/rx/internal/operators/BackpressureUtils.java 68.18% <0%> (-4.55%) 27% <0%> (-2%)
...ain/java/rx/internal/schedulers/SchedulerWhen.java 83.78% <0%> (-4.06%) 4% <0%> (ø)
...ava/rx/internal/operators/OperatorMaterialize.java 85.24% <0%> (-3.28%) 3% <0%> (ø)
...ava/rx/internal/util/BackpressureDrainManager.java 66.66% <0%> (-1.24%) 20% <0%> (-1%)
...in/java/rx/internal/operators/OperatorPublish.java 78.9% <0%> (+0.42%) 8% <0%> (ø)
.../rx/internal/schedulers/CachedThreadScheduler.java 89.32% <0%> (+0.97%) 6% <0%> (ø)
...n/java/rx/subscriptions/CompositeSubscription.java 77.92% <0%> (+1.29%) 25% <0%> (+1%)
...n/java/rx/subjects/SubjectSubscriptionManager.java 82.14% <0%> (+1.42%) 16% <0%> (+1%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a0427b...e698511. Read the comment docs.

@yshrsmz yshrsmz changed the title add unsubscribeOn to Single type (#5138) 1.x: add unsubscribeOn to Single type (#5138) Feb 28, 2017
@akarnokd akarnokd merged commit c8e22d8 into ReactiveX:1.x Mar 12, 2017
@yshrsmz yshrsmz deleted the single-unsubscribeon branch March 12, 2017 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants