Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: TestSubscriber::assertValuesAndClear should reset valueCount #5437

Merged
merged 1 commit into from
Jun 24, 2017

Conversation

mlaux
Copy link

@mlaux mlaux commented Jun 23, 2017

During the time between calling assertValuesAndClear and providing the next onNext event, the valueCount is inconsistent with the size of the internal values list.

@akarnokd akarnokd added this to the 1.4 milestone Jun 23, 2017
@mlaux mlaux force-pushed the fix-testsubscriber-clear branch from a610d5f to 26696d8 Compare June 23, 2017 17:42
@codecov
Copy link

codecov bot commented Jun 23, 2017

Codecov Report

Merging #5437 into 1.x will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                1.x    #5437     +/-   ##
===========================================
- Coverage     84.45%   84.36%   -0.1%     
+ Complexity     2890     2888      -2     
===========================================
  Files           291      291             
  Lines         18129    18130      +1     
  Branches       2479     2479             
===========================================
- Hits          15311    15295     -16     
- Misses         1957     1964      +7     
- Partials        861      871     +10
Impacted Files Coverage Δ Complexity Δ
src/main/java/rx/observers/TestSubscriber.java 81.91% <100%> (+0.09%) 76 <0> (ø) ⬇️
...java/rx/internal/schedulers/ExecutorScheduler.java 77.46% <0%> (-4.23%) 2% <0%> (ø)
...ternal/operators/OperatorOnBackpressureLatest.java 79.04% <0%> (-3.81%) 3% <0%> (ø)
...rx/internal/operators/OperatorMapNotification.java 77.65% <0%> (-2.13%) 2% <0%> (ø)
src/main/java/rx/subjects/UnicastSubject.java 82.71% <0%> (-1.86%) 9% <0%> (ø)
...in/java/rx/internal/operators/OnSubscribeRedo.java 80.64% <0%> (-1.62%) 16% <0%> (ø)
...n/java/rx/subscriptions/CompositeSubscription.java 76.62% <0%> (-1.3%) 25% <0%> (-1%)
...ava/rx/internal/util/BackpressureDrainManager.java 65.43% <0%> (-1.24%) 19% <0%> (-1%)
...main/java/rx/internal/operators/OperatorMerge.java 85.91% <0%> (-0.93%) 7% <0%> (ø)
...n/java/rx/internal/operators/CachedObservable.java 84.23% <0%> (-0.55%) 6% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd023f...26696d8. Read the comment docs.

@akarnokd akarnokd merged commit 3e5b117 into ReactiveX:1.x Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants