Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Update Transforming Observables docs #6291

Merged
merged 3 commits into from
Nov 12, 2018

Conversation

lorenzpahl
Copy link
Contributor

@lorenzpahl lorenzpahl commented Nov 6, 2018

This PR updates the Transforming-Observables.md wiki page as per issue #6132:

  • Add examples
  • Revised descriptions
  • Add more operators

The page now follows the structure that was defined in #6131 .

@lorenzpahl
Copy link
Contributor Author

I know that there are more transformational operators, like Observable::flatMapSingle, Observable::concatMapDelayError, Single::flattenAsFlowable and many more. Should I add more operators to the wiki page?

@akarnokd
Copy link
Member

akarnokd commented Nov 6, 2018

Should I add more operators to the wiki page?

Sure!

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #6291 into 2.x will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6291      +/-   ##
============================================
+ Coverage     98.24%   98.28%   +0.04%     
- Complexity     6281     6282       +1     
============================================
  Files           672      672              
  Lines         44980    44980              
  Branches       6219     6219              
============================================
+ Hits          44189    44209      +20     
+ Misses          251      241      -10     
+ Partials        540      530      -10
Impacted Files Coverage Δ Complexity Δ
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 94.69% <0%> (-3.54%) 11% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 92.7% <0%> (-2.92%) 2% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...ernal/operators/flowable/FlowableFromIterable.java 95.18% <0%> (-1.07%) 5% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 96.58% <0%> (-0.86%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 97.5% <0%> (-0.84%) 2% <0%> (ø)
.../operators/maybe/MaybeFlatMapIterableFlowable.java 97.54% <0%> (-0.82%) 2% <0%> (ø)
...x/internal/operators/flowable/FlowableFlatMap.java 89.47% <0%> (-0.79%) 4% <0%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acd5466...59c193f. Read the comment docs.

@akarnokd akarnokd merged commit 390b7b0 into ReactiveX:2.x Nov 12, 2018
@lorenzpahl lorenzpahl deleted the docs/transforming-observables branch November 12, 2018 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants