Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc: Incorrect Return Types in Javadoc Comments #6344

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

lorenzpahl
Copy link
Contributor

This PR fixes some mistakes in Javadoc comments of some methods inside Flowable.java and Observable.java where the actual return type differs from what is described in the documentation.

Relates to: #4535

@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #6344 into 2.x will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6344      +/-   ##
============================================
- Coverage     98.27%   98.23%   -0.05%     
+ Complexity     6285     6281       -4     
============================================
  Files           672      672              
  Lines         44992    44992              
  Branches       6223     6223              
============================================
- Hits          44218    44196      -22     
- Misses          244      247       +3     
- Partials        530      549      +19
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 567 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 542 <0> (ø) ⬇️
...ex/internal/subscriptions/SubscriptionArbiter.java 97.47% <0%> (-2.53%) 50% <0%> (-1%)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...java/io/reactivex/processors/PublishProcessor.java 98.19% <0%> (-1.81%) 42% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-1.64%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-1.5%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 92.75% <0%> (-1.45%) 2% <0%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc40695...bfebeb2. Read the comment docs.

@akarnokd akarnokd added this to the 2.2 backlog milestone Dec 15, 2018
@akarnokd akarnokd merged commit 913e800 into ReactiveX:2.x Dec 19, 2018
@lorenzpahl lorenzpahl deleted the docs/fix-incorrect-return-type branch January 2, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants