-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor forwardStream: uses Stream.multi
#605
Conversation
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
==========================================
- Coverage 93.39% 93.22% -0.17%
==========================================
Files 70 71 +1
Lines 2256 2230 -26
==========================================
- Hits 2107 2079 -28
- Misses 149 151 +2 |
A special case cannot be handled :(( test('description', () async{
final a = BehaviorSubject.seeded('b');
final bug = a.doOnData((v) {});
await bug.listen(null).cancel();
expect(await bug.first, 'b'); // cannot complete
}); |
I also tried converting to Stream.multi, but where my attempt fails, so does this one, take this test for example: test('issue/587', () async {
final source = BehaviorSubject.seeded('source');
final switched =
source.switchMap((value) => BehaviorSubject.seeded('switched'));
var i = 0;
switched.listen((_) => i++);
expect(await switched.first, 'switched');
expect(i, 1);
expect(await switched.first, 'switched');
expect(i, 1);
}); |
* failed * sink per stream
I have just skipped some tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay again!
Awesome job yet again :)
And great to hear the deadlocks are solved!
Based on #596 and #601