Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BufferedSubject #666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add BufferedSubject #666

wants to merge 1 commit into from

Conversation

tjarvstrand
Copy link

No description provided.

@tjarvstrand
Copy link
Author

tjarvstrand commented Nov 5, 2022 •
edited

Is anyone even looking at these PRs?

@hoc081098 You seem to be the most active committer in this repository lately. Do you have any input?

@hoc081098
Copy link
Collaborator

Hi @tjarvstrand, I think it is not a standard Subject in ReactiveX

@tjarvstrand
Copy link
Author

Ah, is that a requirement?

@hoc081098
Copy link
Collaborator

Yes.

  • A similar case:
    This subject is similar to DispatchWorkSubject, but DispatchWorkSubject is in RxJavaExtensions instead of RxJava
  • You can include this subject in a other library with a easy effort. For me, I have created StateSubject and included it in my library rxdart_ext
  • We should keep rxdart as minimal as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tjarvstrand @hoc081098