chore(Subscriber): remove _addParentTeardownLogic

ReactiveX · Sep 14, 2018 · 1cc1070 · 1cc1070
1 parent 6dc62e3
commit 1cc1070
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/spec/Subscriber-spec.ts b/spec/Subscriber-spec.ts
@@ -23,8 +23,8 @@ describe('Subscriber', () => {
   it('should accept subscribers as a destination if they meet the proper criteria', () => {
     const fakeSubscriber = {
       [rxSubscriber](this: any) { return this; },
-      _addParentTeardownLogic() { /* noop */ },
-      add() { /* noop */ }
+      add() { /* noop */ },
+      syncErrorThrowable: false
     };
 
     const subscriber = new Subscriber(fakeSubscriber as any);

diff --git a/src/internal/Subscriber.ts b/src/internal/Subscriber.ts
@@ -154,11 +154,6 @@ export class Subscriber<T> extends Subscription implements Observer<T> {
     this.unsubscribe();
   }
 
-  /** @deprecated This is an internal implementation detail, do not use. */
-  _addParentTeardownLogic(parentTeardownLogic: TeardownLogic) {
-    /*noop*/
-  }
-
   /** @deprecated This is an internal implementation detail, do not use. */
   _unsubscribeAndRecycle(): Subscriber<T> {
     const { _parent, _parents } = this;
@@ -315,5 +310,5 @@ export class SafeSubscriber<T> extends Subscriber<T> {
 }
 
 function isTrustedSubscriber(obj: any) {
-  return obj instanceof Subscriber || ('_addParentTeardownLogic' in obj && obj[rxSubscriberSymbol]);
+  return obj instanceof Subscriber || ('syncErrorThrowable' in obj && obj[rxSubscriberSymbol]);
 }