Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Symbol.observable): make observable declaration readonly (#3697) #3773

Merged
merged 1 commit into from
Jun 1, 2018
Merged

fix(Symbol.observable): make observable declaration readonly (#3697) #3773

merged 1 commit into from
Jun 1, 2018

Conversation

scttcper
Copy link
Contributor

@scttcper scttcper commented Jun 1, 2018

rxjs symbol declaration creates error when combined with other packages

closes #3697

@david-driscoll
Copy link
Member

@benlesh this may affect rxjs 5 as well, not sure if we want to patch it down that way or not.

@benlesh
Copy link
Member

benlesh commented Jun 1, 2018

@david-driscoll this shouldn't affect RxJS 5 at all. if it does, it's because someone is doing something broken in TypeScript like assigning Symbol.observable = 'whatever'... if that's the case, they can just cast as any and fix. This is solving a bug, and isn't something we need to put off to another major version.

@benlesh benlesh merged commit e1c203f into ReactiveX:master Jun 1, 2018
@benlesh
Copy link
Member

benlesh commented Jun 1, 2018

Thank you, @scttcper!

@amaury1093
Copy link

amaury1093 commented Jun 7, 2018

Just to make sure: this isn't out yet in 6.2.0, correct?

Do you have an alpha version at par with master?

@paulstelzer
Copy link

paulstelzer commented Jun 8, 2018

@amaurymartiny It's not out yet and as you can see at https://www.npmjs.com/package/rxjs?activeTab=versions there is no new alpha or beta version. Just downgrade to @types/node@10.1.4 so everything is still working

@saeedkhan-github
Copy link

how to downgrad to @types/node@10.1.4 ?

@JohannesHoppe
Copy link

npm install @types/node@10.1.4

@paulstelzer
Copy link

rxjs@6.2.1 is online, so you do not need to downgrade @types/node - just update to the latest version of rxjs

@michelmob
Copy link

the same here. I'm using:

"rxjs": "^6.2.1",
"rxjs-compat": "^6.2.1",

and

"@types/node": "^10.1.4"

help?

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jul 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript interface augmentation for SymbolConstructor conflicts with symbol-observable
9 participants