Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dtslint): add higher-order observable tests #3958

Merged
merged 1 commit into from
Jul 27, 2018

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Jul 26, 2018

Description:

I should have included these dtslint tests in #3945 to show that the change does fix the reported issue. It does.

Related issue (if exists): #3841

@cartant
Copy link
Collaborator Author

cartant commented Jul 26, 2018

I don't know what the problem within Travis relates to. I've cleared the cache, but the error persists.

Also, checking the tags for the module mentioned in the error - definitelytyped-header-parser - effects this error:

$ npm dist-tag ls definitelytyped-header-parser
npm WARN notice Due to a recent security incident, all user tokens have been invalidated. Please see https://status.npmjs.org/incidents/dn7c1fgrr7ng for more details. To generate a new token, visit https://www.npmjs.com/settings/~/tokens or run "npm login".
npm ERR! dist-tag ls Couldn't get dist-tag data for definitelytyped-header-parser
npm ERR! code E404
npm ERR! 404 Registry returned 404 for GET on https://registry.npmjs.org/-/package/definitelytyped-header-parser/dist-tags

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\Nicholas\AppData\Roaming\npm-cache\_logs\2018-07-26T23_49_25_070Z-debug.log

@kwonoj
Copy link
Member

kwonoj commented Jul 27, 2018

:wat: error message doesn't...make sense, why we are encountering error for token when try to install something?

@cartant
Copy link
Collaborator Author

cartant commented Jul 27, 2018

@kwonoj Yeah, I know. I don't know whether there is some weirdness happening with npm in general or if the lock file was somehow messed up in f0ac727

However, running npm ci here - using npm v6.2.0 - with the latest master effects the same error on my computer. So I think I'm inclined to do an npm uninstall --save-dev dtslint and npm install --save-dev --save-exact dtslint to update the lock file. Or maybe I should just regenerate the lock file?

@kwonoj
Copy link
Member

kwonoj commented Jul 27, 2018

So I think I'm inclined to do an npm uninstall --save-dev dtslint and npm install --save-dev --save-exact dtslint to update the lock file.

I think that's worth to try. If that still doesn't work, feel free to burn current pkg lock and regenrate. We are relatively free from pkglock since our deps are mostly devdeps, so no worries of prod pkg inconsistency.

@cartant
Copy link
Collaborator Author

cartant commented Jul 27, 2018

An uninstall/install of dtslint fixed it for me on this comuter. See #3959.

@kwonoj
Copy link
Member

kwonoj commented Jul 27, 2018

the mysterious world of npm.

@benlesh
Copy link
Member

benlesh commented Jul 27, 2018

I'm calling bullshit on npm and merging anyway. haha... Damn the torpedoes!

@benlesh benlesh merged commit 310b9f5 into ReactiveX:master Jul 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 26, 2018
@cartant cartant deleted the issue-3841-2 branch September 24, 2020 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants