Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Notification): replace const enum #4556

Merged
merged 2 commits into from Apr 23, 2019
Merged

fix(Notification): replace const enum #4556

merged 2 commits into from Apr 23, 2019

Commits on Mar 26, 2019

  1. fix(Notification): replace const enum 

    Closes ReactiveX#4538
    @cartant
    cartant committed Mar 26, 2019
    Copy the full SHA
    b28521d View commit details
    Browse the repository at this point in the history

  2. chore: use literal union and keep enum 

    The enum is kept, but it is no longer a const enum. It cannot be exported as a const enum without effecting an error if isolated modules are used.
    @cartant
    cartant committed Mar 26, 2019
    Copy the full SHA
    ca0afc0 View commit details
    Browse the repository at this point in the history