Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Subscription): Return Empty when teardown === null #4575

Merged
merged 2 commits into from May 10, 2019
Merged

fix(Subscription): Return Empty when teardown === null #4575

merged 2 commits into from May 10, 2019

Commits on Feb 18, 2019

  1. fix(Subscription): Return Empty when teardown === null 

    `typeof teardown` returns object when null. It breaks later when rxjs tries to access the closed property.

The commit fixes that by first checking for null/undefined.
    @ChristianKohler
    ChristianKohler committed Feb 18, 2019
    Copy the full SHA
    7d8f21a View commit details
    Browse the repository at this point in the history

  2. fix(Subscription): tslint errors

    Chris authored and Chris committed Feb 18, 2019
    Copy the full SHA
    c4a8bc0 View commit details
    Browse the repository at this point in the history