fix(scan-operator): Improve typings using newer TS features #4763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
scan
operator does not properly infer types when the output Observable type differs from the input Observable type (i.e.T != R
). This issue was discussed at length a few years back in #2897. That PR was ultimately closed because there were unavoidable limitations due to the minimum supported TypeScript at that time. The current minimum TS version should allow these types to be improved.Using issue #3150 as an example:
The current types cause both
acc
andstr
to be inferred as astring
type, butacc
should be inferred to be anumber
from the seed value0
, which is what my change fixes.Related issue (if exists):
#3150