Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Resolve issues downstream at Google #4975

Closed
wants to merge 1 commit into from

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Aug 20, 2019

Unfortunately I don't remember what this resolved, I think there was an issue with TypeScript compilation in Google's more strict environment.

Unfortunately I don't remember what this resolved, I think there was an issue with TypeScript compilation in Google's more strict environment.
@kolodny
Copy link
Member

kolodny commented Aug 21, 2019

Note, this also needs to be done for

  • src/internal/util/ArgumentOutOfRangeError.ts
  • src/internal/util/ObjectUnsubscribedError.ts
  • src/internal/util/UnsubscriptionError.ts
  • src/internal/util/TimeoutError.ts
  • src/internal/util/EmptyError.ts

@benlesh
Copy link
Member Author

benlesh commented Aug 22, 2019

Closed in favor of #4978

@benlesh benlesh closed this Aug 22, 2019
@benlesh benlesh deleted the benlesh-patch-UnsubscriptionError branch August 22, 2019 15:25
@lock lock bot locked as resolved and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants