Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(groupBy): Support named arguments, support ObservableInputs for duration selector #5679

Merged
merged 4 commits into from May 20, 2021

Commits on Apr 29, 2021

  1. feat(groupBy): Support named arguments, support ObservableInputs for …

    …duration selector
    
    - Adds support for named arguments.
    - Adds support for returning promises, et al, from the duration selector.
    
    NOTES:
    
    * There's a problem with type inferrence from the options `duration` selector that is noted in a `TODO` in the code here.
    * The tests for `groupBy` appear to be EXTREMELY old and outdated, and I was unable to updated them easily to use run mode. We may have to rewrite them all at some point to use better techniques. The issue seems to be a rudementary means of testing the inner observables that is incompatible with run mode.
    * Docs still need updated
    * Older paths still need to be deprecated
    * dtslint tests need to be added
    benlesh committed Apr 29, 2021
    Copy the full SHA
    f7db0dd View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    9c26c40 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    2ac05da View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Copy the full SHA
    c376360 View commit details
    Browse the repository at this point in the history