Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add types to the package export map #6642

Closed
wants to merge 1 commit into from

Conversation

demurgos
Copy link

Description:

This commit adds types mapping for the package exports. It makes the package compatible with the upcoming node12 module resolution in TypeScript 4.5.0.

BREAKING CHANGE: N/A

Related issue (if exists): #6641

This commit adds `types` mapping for the package `exports`. It makes the package compatible with the upcoming `node12` module resolution in TypeScript 4.5.0.

Closes ReactiveX#6641
@kwonoj
Copy link
Member

kwonoj commented Oct 29, 2021

Ref original issue's comment #6641 (comment) .

@kwonoj
Copy link
Member

kwonoj commented Nov 2, 2021

I'm going to close this for now based on Typescript Team's decision (https://devblogs.microsoft.com/typescript/announcing-typescript-4-5-rc/#beta-delta) to not include this for the release:

If you try to use these settings in TypeScript 4.5 RC or stable, you’ll receive an error message directing you to use a nightly build instead

We'll eventually try to support latest tsc features as much to align with ecosystem, but given upstream tsc would like to observe things more carefully and it's not availble for general purpose I don't think we can release our package with this at this moment.

@frank-dspeed
Copy link

frank-dspeed commented Feb 10, 2022

@kwonoj reopen and release this was wrong communicated it did ship it is released @DanielRosenwasser was referencing to the stuff that is listed under concerns not the modes it self sorry for that.

@kwonoj
Copy link
Member

kwonoj commented Feb 10, 2022

Isn't this same as #6802 filed recently?

@frank-dspeed
Copy link

@kwonoj your correct and andrew is from the typescript team ok i got confused because the person who created this pull request posted that he did a pull request before and then i reviewed this.

but andrews pull is newer so ok your correct merge #6802 LGTM +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants