Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: isolated module set to true, exports split to export type #6800

Closed
wants to merge 2 commits into from

Conversation

ziv
Copy link

@ziv ziv commented Feb 7, 2022

Description:

In order to be more compatible with ESM and other bundlers or TypeScript environment (Babel and Deno, for example), isolatedModules flag should be turned on.

This PR contain only this change in tsconfig and fix some build error (replace "export" with "export type" for interfaces).
Reference:
https://www.typescriptlang.org/tsconfig#isolatedModules

All tests and build pass.

@jakovljevic-mladen
Copy link
Member

Hi @ziv, unfortunately, we already had an attempt to introduce export type syntax to the repo, but it failed due to docs app being unable to generate documentation for these types (GlobalConfig, RetryConfig and all others). Please take a look at this PR (and this comment) and the reverting PR.

I'd close this PR, but since it also includes isolatedModules: true change, I'll check with the core team how/should we include this.

@jakovljevic-mladen jakovljevic-mladen added the AGENDA ITEM Flagged for discussion at core team meetings label Oct 14, 2022
@benlesh
Copy link
Member

benlesh commented Dec 14, 2022

Closing this. It doesn't seem like this is solving any issues we're currently having. Thank you for your contribution, @ziv .

@benlesh benlesh closed this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AGENDA ITEM Flagged for discussion at core team meetings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants