Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(SafeSubscriber): optimize perf for ordinary observers #6815

Merged
merged 3 commits into from Feb 9, 2022
Merged

refactor(SafeSubscriber): optimize perf for ordinary observers #6815

merged 3 commits into from Feb 9, 2022

Commits on Feb 8, 2022

  1. refactor(SafeSubscriber): optimize perf for ordinary observers 

    No longer require function binding if we aren't using the deprecated next context. This should improve performance in the common path of consumers subscribing with an object or even with a function.

Adds a simple class `ConsumerObserver` which is mostly meant to optimize the number of function refrences created. We should never expose this externally.

Related ReactiveX#6783
    @benlesh
    benlesh committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    59ca19e View commit details
    Browse the repository at this point in the history

  2. chore: update comments

    @benlesh
    benlesh committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    3d0325f View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. refactor(Subscriber): reduce property access

    @benlesh
    benlesh committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    d2bbc4c View commit details
    Browse the repository at this point in the history