Subscriber refactor for version 8 #6817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
commented
Feb 8, 2022
| * `bind`. In particular, a library called Monio requires this. | ||
| */ | ||
| const _bind = Function.prototype.bind; | ||
| class ConsumerObserver<T> implements Observer<T> { |
benlesh
commented
Feb 8, 2022
src/internal/Subscriber.ts
Outdated
| try { | ||
| this.partialObserver.next(value); | ||
| } catch (error) { | ||
| reportUnhandledError(error); |
There was a problem hiding this comment.
Note the difference here because we don't have to worry about deprecated error behavior.
benlesh
commented
Feb 8, 2022
| return value && isFunction(value.next) && isFunction(value.error) && isFunction(value.complete); | ||
| } | ||
|
|
||
| export function isSubscriber<T>(value: any): value is Subscriber<T> { |
benlesh
commented
Feb 8, 2022
| project, | ||
|
|
||
| // HACK: Cast because TypeScript seems to get confused here. | ||
| project as (value: T, index: number) => ObservableInput<ObservedValueOf<O>>, |
There was a problem hiding this comment.
This was super weird, but seems like an inference quirk with TypeScript.
benlesh
commented
Feb 8, 2022
| @@ -40,6 +41,6 @@ import { noop } from '../util/noop'; | |||
| */ | |||
| export function ignoreElements(): OperatorFunction<unknown, never> { | |||
| return operate((source, subscriber) => { | |||
| source.subscribe(createOperatorSubscriber(subscriber, noop)); | |||
| source.subscribe(createOperatorSubscriber(subscriber as Subscriber<unknown>, noop)); | |||
There was a problem hiding this comment.
Subscriber<never> doesn't match Subscriber<unknown> (or even Subscriber<any>, because never, haha)
benlesh
commented
Feb 8, 2022
| } | ||
| } else { | ||
| this.destination = EMPTY_OBSERVER; | ||
| this.destination = isSubscriber(destination) ? destination : createSafeObserver(destination); |
There was a problem hiding this comment.
important magic here!
If we have a Subscriber, then just use that, otherwise we don't know what it is, and we need to make a safe observer.
If you step through the commits, you find out that this is all SafeSubscriber was doing, which is why we removed it.
benlesh
commented
Feb 8, 2022
|
|
||
| function bind<Fn extends (...args: any[]) => any>(fn: Fn, thisArg: any): Fn { | ||
| return _bind.call(fn, thisArg); | ||
| } |
There was a problem hiding this comment.
The bind stuff can be removed! Yay.
ajafff
reviewed
Feb 9, 2022
+ Removes `Subscriber.create`. + Removes `SafeSubscriber`, which is no longer necessary. BREAKING CHANGE: Subscriber.create has been removed. Please use `new Subscriber` instead.
- Move to using `new Subscriber` throughout the library - undeprecate `new Subscriber`. - Correct typings for `destination` on `Subscriber`. - Removes `createSafeSubscriber` internal function.
- updates API guardian files - updates side-effects files - fixes a couple of minor typings issues - fixes circular dependency for isSubscriber
benlesh
force-pushed
the
v8-subscriber-refactor
branch
from
2fe4099
to
0a22d06
Compare
cartant
approved these changes
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is completely based off of #6815, but taken with a commit-by-commit refactor of related pieces.
Highlights:
Subscriberconstructor is no longer deprecated. It can be used to create a "safe subscriber" likenew Subscriber(nextHandler)ornew Subscriber({ next, error }), etc.Subscriber.createAPI has been removed.SafeSubscriberremoved. Everything is now simplified.NOTE: Please review one commit at a time. I tried to keep the individual commits small and focused.