Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript 4.6 compatibility #6895

Merged
merged 3 commits into from Mar 28, 2022
Merged

Typescript 4.6 compatibility #6895

merged 3 commits into from Mar 28, 2022

Commits on Mar 15, 2022

  1. fix(typescript): type check failures in typescript 4.6

    @sundbry
    sundbry committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    41c8c13 View commit details
    Browse the repository at this point in the history

  2. fix(timers): TimerHandle type to resolve node/browser timer handle types 

    setInterval/setTimeout/setImmediate have different return types in
node.js and the browser. Define TimerHandle to abstract the difference
and fix compilation errors where the return type was a number.
    @sundbry
    sundbry committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    fd5d8a0 View commit details
    Browse the repository at this point in the history

  3. Use export type for re-exporting type definitions 

    Fixes compilation under typescript with `isolatedModules: true`

See https://devblogs.microsoft.com/typescript/announcing-typescript-3-8/#type-only-imports-exports
    @sundbry
    sundbry committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    ba2794a View commit details
    Browse the repository at this point in the history