Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(combineLatest): removed deprecated combineLatest operator #7000

Closed
wants to merge 1 commit into from
Closed

feat(combineLatest): removed deprecated combineLatest operator #7000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
112 changes: 0 additions & 112 deletions spec-dtslint/operators/combineLatest-spec.ts
View file
Open in desktop

This file was deleted.

13 changes: 8 additions & 5 deletions spec/Observable-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { expect } from 'chai';
import * as sinon from 'sinon';
import { TeardownLogic } from '../src/internal/types';
import { Observable, config, Subscription, Subscriber, Operator, NEVER, Subject, of, throwError, EMPTY } from 'rxjs';
import { map, multicast, refCount, filter, count, tap, combineLatest, concat, merge, race, zip, catchError, publish, publishLast, publishBehavior, share} from 'rxjs/operators';
import { map, multicast, refCount, filter, count, tap, combineLatestWith, concat, merge, race, zip, catchError, publish, publishLast, publishBehavior, share} from 'rxjs/operators';
import { TestScheduler } from 'rxjs/testing';
import { observableMatcher } from './helpers/observableMatcher';

Expand Down Expand Up @@ -132,7 +132,7 @@ describe('Observable', () => {
},
(err) => {
results.push(err);
// The error should unsubscribe from the source, meaning we
// The error should unsubscribe from the source, meaning we
// should not see the number 4.
expect(results).to.deep.equal([1, 2, 3, expected]);
}
Expand Down Expand Up @@ -179,7 +179,7 @@ describe('Observable', () => {
results.push(value);
}
next.bind = () => { /* lol */};

const complete = function () {
results.push('done');
}
Expand Down Expand Up @@ -1051,13 +1051,16 @@ describe('Observable.lift', () => {
);
});

it('should compose through combineLatest', () => {
it('should compose through combineLatestWith', () => {
rxTestScheduler.run(({ cold, expectObservable }) => {
const e1 = cold(' -a--b-----c-d-e-|');
const e2 = cold(' --1--2-3-4---| ');
const expected = '--A-BC-D-EF-G-H-|';

const result = MyCustomObservable.from(e1).pipe(combineLatest(e2, (a, b) => String(a) + String(b)));
const result = MyCustomObservable.from(e1).pipe(
combineLatestWith(e2),
map(([a, b]) => String(a) + String(b))
);

expect(result instanceof MyCustomObservable).to.be.true;

Expand Down