Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(type): discard redundant ValueFromArray #7171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(type): discard redundant ValueFromArray #7171

wants to merge 1 commit into from

Conversation

demensky
Copy link
Contributor

TypeScript has an easy way to get the type of array's value. This method works even in older versions. As you can see from the endWith example, this method calculates the type more reliably, this allowed us to remove the as hack.

benlesh
benlesh requested changes Jan 25, 2023
View reviewed changes
Copy link
Member

@benlesh benlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is a breaking change. Anyone that was using this exported type would be effected. We need to at least mark it as such.

@demensky
Copy link
Contributor Author

Reverted back ValueFromArray and marked it as @deprecated.

@demensky demensky requested a review from benlesh March 9, 2023 11:08
@demensky demensky force-pushed the discard-value-from-array branch 2 times, most recently from e893705 to 915f833 Compare April 17, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LcsGa LcsGa LcsGa approved these changes

@benlesh benlesh Awaiting requested review from benlesh

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@demensky @benlesh @LcsGa