Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix every re-entrancy and signature. #7432

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Jan 22, 2024

BREAKING CHANGE: `every` operator no longer supports providing `thisArg`. Use `Function#bind` or closure instead.
BREAKING CHANGE: `every` no longer provides the source observable as the third argument to the predicate. Use a closure instead.
Copy link
Member

@jakovljevic-mladen jakovljevic-mladen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably find a way to port the re-entrancy fix to 7.x, right?

@benlesh benlesh merged commit c666574 into ReactiveX:master Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants