Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render date #283

Closed
wants to merge 25 commits into from
Closed

Render date #283

wants to merge 25 commits into from

Conversation

akshay1502
Copy link
Contributor

@akshay1502 akshay1502 commented Aug 18, 2022

Using date formating in

  • tasks route
  • openPr
  • stalePr
  • mine

in tasks,mine we have dates in number format
while for openPr, stalePr we have dates in string format
Handling both number and string format of dates.

before

datebeforerds

after

dateafterrds

@akshay1502
Copy link
Contributor Author

redwoodjs/redwood#5104 (comment)
https://stackoverflow.com/a/71828113/13964048
Added resultions due to following error.
Screenshot (200)
l

@akshay1502 akshay1502 self-assigned this Aug 20, 2022
@akshay1502 akshay1502 linked an issue Aug 20, 2022 that may be closed by this pull request
src/utils/renderDate.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Maheima
Copy link
Contributor

Maheima commented Aug 24, 2022

LGTM

@ivinayakg
Copy link
Contributor

LGTM

@ankushdharkar
Copy link
Contributor

Why was the yarn.lock deleted??

Copy link
Contributor

@ivinayakg ivinayakg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshay1502 remove the yarn.lock file changes from the pr

@akshay1502
Copy link
Contributor Author

Now I know how to deal with yarn.lock.

@sahsisunny sahsisunny closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract Component - Render Date
6 participants