Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add products pagination #115

Merged

Conversation

Hyperkid123
Copy link
Contributor

Changes

  • now can select products only from one source at a time
  • adds pagination when selecting products
  • refactoring AddProductsToPortfolio component
    • split into multiple components
    • uses hooks instead of React classes
    • less code better performance (yes this PR adds more code overall but that is caused by tests and strict prop type checking)

Issues

products-pagination

@Hyperkid123 Hyperkid123 added the enhancement New feature or request label Mar 12, 2019
@miq-bot
Copy link
Collaborator

miq-bot commented Mar 12, 2019

Checked commits Hyperkid123/service_portal-ui@9217e3c~...73b2f04 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@gmcculloug
Copy link
Contributor

@Hyperkid123 Is the idea to add controls at the top and bottom of the page as Susan mentioned today?

@martinpovolny Please review.

@Hyperkid123
Copy link
Contributor Author

@gmcculloug So the official place for pagination is either top or the bottom. Deepens on the use case. If you can't see the pagination toolbar on the screen (you have to scroll down) then they should be at the top. Susan actually updated mocks and on the card views the pagination is placed on the top toolbar like in the gif. Pagination on the bottom should be mostly on tables and similar components.

@martinpovolny martinpovolny merged commit ca4ad43 into RedHatInsights:master Mar 13, 2019
@Hyperkid123 Hyperkid123 deleted the add-products-pagination branch March 13, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants