hccdoc-2342 Neutral filenames, CUR>data export, and OCI link fix #1211
Conversation
|
Can one of the admins verify this patch? |
neal-timpe
force-pushed
the
update-cost-doc-links-hccdoc-2342
branch
from
6806d3d
to
7b3ce87
Compare
|
@fhlavac I feel like the checklist is filled in, but I can't figure out why the linter threw an error on whitespace that I didn't change. It's my first PR for this project, so sorry about that. |
| defaultMessage: | ||
| 'In your Oracle Cloud account, create a VM and run a script similar to the one from this github repository:', | ||
| 'In your Oracle Cloud account, create a VM and run a script provided in the documentation:', |
There was a problem hiding this comment.
here, the linter wants just put "defaultMessage" and the string on the same line
| screen.getByText( | ||
| 'In your Oracle Cloud account, create a VM and run a script similar to the one from this github repository:', | ||
| 'In your Oracle Cloud account, create a VM and run a script provided in the documentation', | ||
| ), |
There was a problem hiding this comment.
and the same here, just put it all on a single line
|
I cannot see any more issues, running the lint script with |
There was a problem hiding this comment.
Here, you are updating the test, but the code (in arn.js) still contains the old wording - that's why the tests are failing
| screen.getByText( | ||
| 'In your Oracle Cloud account, create a VM and run a script similar to the one from this github repository:', | ||
| ), | ||
| screen.getByText('In your Oracle Cloud account, create a VM and run a script provided in the documentation'), |
There was a problem hiding this comment.
| screen.getByText('In your Oracle Cloud account, create a VM and run a script provided in the documentation'), | |
| screen.getByText('In your Oracle Cloud account, create a VM and run a script provided in the documentation:'), |
| screen.getByText( | ||
| 'In your Oracle Cloud account, create a VM and run a script similar to the one from this github repository:', | ||
| ), | ||
| screen.getByText('In your Oracle Cloud account, create a VM and run a script provided in the documentation'), | ||
| ).toBeInTheDocument(); | ||
| expect( | ||
| screen.getByText( |
There was a problem hiding this comment.
this assertion probably needs updating to Replicating reports to a bucket
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1211 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 184 184
Lines 3702 3702
Branches 1053 1053
=======================================
Hits 3619 3619
Misses 77 77
Partials 6 6 ☔ View full report in Codecov by Sentry. |
|
Thanks! @fhlavac My local linter was coming up with some other nonsense that I couldn't figure out and I didn't want to keep committing, but it looks like it came out okay with your help! :) |
neal-timpe
force-pushed
the
update-cost-doc-links-hccdoc-2342
branch
from
88a25cc
to
4c7077e
Compare
Description
This fixes links and link text issues the integration wizard in three parts. First, in conjunction with hccdoc-2342, this changes the filenames in some cost management docs so that they don't have HCS in the URL and makes the links from the sources UI point to the correct locations.
For HCCDOC-2389, it changes CUR to data export to track with a change made in HCS.
And as part of HCSDOC-2363, it fixes a naked URL link to the docs and covers it with appropriate link text.
Screenshots
After:
It should say after
In your Oracle Cloud account, create a VM and run a script the documentation: Replicating reports to a bucketChecklist ☑️