Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal function inOrEqual #2882

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

nafraf
Copy link
Contributor

@nafraf nafraf commented Feb 12, 2023

This PR is to solve #2854: "WHERE element IN list - should cast runtime non-list to a single-element list"

The proposed change is to create a new internal function inOrEqual that is called in case of in operator when the second argument is of type property operator.

The function inOrEqual receives two arguments and returns true in the following cases:

  1. arg2 is list and arg1 is in arg2
  2. arg1 is equal to arg2

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Base: 91.39% // Head: 91.37% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (506a237) compared to base (e05946e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2882      +/-   ##
==========================================
- Coverage   91.39%   91.37%   -0.03%     
==========================================
  Files         272      272              
  Lines       26223    26248      +25     
==========================================
+ Hits        23967    23984      +17     
- Misses       2256     2264       +8     
Impacted Files Coverage Δ
src/arithmetic/arithmetic_expression_construct.c 93.73% <100.00%> (+0.05%) ⬆️
src/arithmetic/list_funcs/list_funcs.c 99.05% <100.00%> (+0.06%) ⬆️
src/procedures/proc_ss_paths.c 90.40% <0.00%> (-1.75%) ⬇️
src/procedures/proc_sp_paths.c 95.70% <0.00%> (-0.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nafraf nafraf marked this pull request as ready for review February 13, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants