New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.10] MOD-6135: build macos-m1 #3218
Open
nafraf
wants to merge
17
commits into
2.10
Choose a base branch
from
nafraf_2.10-build-macos-m1-v2
base: 2.10
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there were failures while running the tests, usually in cases when the `redis-server` was installed via homebrew and/or it was impossible to configure it via the config file, and which (of course) wasn't built with the debug command being enabled by default. This enables the debug command when running the `redis-server`, so the tests will pass now.
This reverts commit 4c3818a.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #3218 +/- ##
==========================================
- Coverage 92.41% 92.36% -0.05%
==========================================
Files 264 264
Lines 25307 25296 -11
==========================================
- Hits 23387 23365 -22
- Misses 1920 1931 +11 ☔ View full report in Codecov by Sentry. |
nafraf
changed the title
MOD-6135: [2.10] build macos-m1
[2.10] MOD-6135: build macos-m1
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOD-6135
Based on: CircleCI: macOS/M1 (#2976)
Update readies: 0f682ae
Update timeout tests based on: Fix ci issues 1 (#2846)
Cherry-picked PRs
Fix flaky timeout (#3110)
Enable running the tests by enabling debug command. (#2713)
fix ci issue (#2833)
fix flaky test (#3108)
Fix valgrind build (#2875)