Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.10] MOD-6135: build macos-m1 #3218

Open
wants to merge 17 commits into
base: 2.10
Choose a base branch
from
Open

Conversation

nafraf
Copy link
Contributor

@nafraf nafraf commented Nov 15, 2023

MOD-6135

Based on: CircleCI: macOS/M1 (#2976)
Update readies: 0f682ae
Update timeout tests based on: Fix ci issues 1 (#2846)

Cherry-picked PRs
Fix flaky timeout (#3110)
Enable running the tests by enabling debug command. (#2713)
fix ci issue (#2833)
fix flaky test (#3108)
Fix valgrind build (#2875)

nafraf and others added 11 commits November 14, 2023 19:11
Previously there were failures while running the tests, usually in cases when
the `redis-server` was installed via homebrew and/or it was impossible to
configure it via the config file, and which (of course) wasn't built with the
debug command being enabled by default.

This enables the debug command when running the `redis-server`, so the tests will
pass now.
@nafraf nafraf changed the title [2.10] build macos-m1 MOD-6135: [2.10] build macos-m1 Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (91bd94c) 92.41% compared to head (5b2040c) 92.36%.

Files Patch % Lines
src/util/thpool/thpool.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.10    #3218      +/-   ##
==========================================
- Coverage   92.41%   92.36%   -0.05%     
==========================================
  Files         264      264              
  Lines       25307    25296      -11     
==========================================
- Hits        23387    23365      -22     
- Misses       1920     1931      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nafraf nafraf marked this pull request as ready for review November 16, 2023 03:58
@nafraf nafraf changed the title MOD-6135: [2.10] build macos-m1 [2.10] MOD-6135: build macos-m1 Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants