Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix oneOf being sampled twice for the first item in the list #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix oneOf being sampled twice for the first item in the list #146

wants to merge 1 commit into from

Conversation

thiagonuic
Copy link

What/Why/How?

Details on this change can be found in the issue:
#145

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@thiagonuic thiagonuic requested a review from a team as a code owner January 2, 2023 11:39
@thiagonuic thiagonuic requested review from Oprysk and removed request for a team January 2, 2023 11:39
@adamaltman
Copy link
Member

I think we would want to consider min/max items in the schema definition as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itungnt itungnt itungnt approved these changes

@Oprysk Oprysk Awaiting requested review from Oprysk Oprysk is a code owner automatically assigned from Redocly/keyboard-warriors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thiagonuic @adamaltman @itungnt