Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ab#88348 grid does not support is primitive value unchecked #1000

Open
wants to merge 2 commits into
base: 2.x.x
Choose a base branch
from

Conversation

NathanHGit
Copy link
Contributor

@NathanHGit NathanHGit commented Mar 19, 2024

Description

When a question is linked to a reference data, the values saved with the form take different formats depending on whether they are primitive or non-primitive values. As a result, non-primitive value returned an object instead of an id, and the data weren't correctly loaded. It affected all type of widgets (grid, summary cards, and so on).

To fix it, I manually changed the format from the backend. I'm not sure if it's the best solution and if it might break other functionalities, but according to my tests, it seems to work fine.

Useful links

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I created a form with a question linked to a reference data and configured it as non-primitive value. I saved records using it, displayed them in a grid and checked if they were displayed correctly.

Screenshots

peek

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@NathanHGit NathanHGit added the bug Something isn't working label Mar 19, 2024
@NathanHGit NathanHGit self-assigned this Mar 19, 2024
@NathanHGit NathanHGit requested a review from a team March 19, 2024 15:49
@TaiKamilla TaiKamilla requested review from TaiKamilla and removed request for TaiKamilla April 5, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant