Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ab#74335 create wysiwyg editor question #1001

Open
wants to merge 2 commits into
base: 2.x.x
Choose a base branch
from
Open

Ab#74335 create wysiwyg editor question #1001

wants to merge 2 commits into from

Conversation

MwanPygmay
Copy link
Contributor

@MwanPygmay MwanPygmay commented Mar 22, 2024 •
edited

Description

Add support for the editor question

Useful links

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@MwanPygmay MwanPygmay self-assigned this Mar 26, 2024
@MwanPygmay MwanPygmay mentioned this pull request Mar 26, 2024
Closed
15 tasks
@MwanPygmay MwanPygmay marked this pull request as ready for review March 26, 2024 15:09
@NathanHGit NathanHGit added the enhancement Existing feature label Mar 29, 2024
@NathanHGit NathanHGit self-requested a review March 29, 2024 08:53
NathanHGit
NathanHGit approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@NathanHGit NathanHGit left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine!

@estelafs estelafs mentioned this pull request May 8, 2024
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanHGit NathanHGit NathanHGit approved these changes

Assignees

@MwanPygmay MwanPygmay

Labels
enhancement Existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MwanPygmay @NathanHGit