Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB#89564 new button action types dashboard #1017

Open
wants to merge 3 commits into
base: 2.x.x
Choose a base branch
from

Conversation

Maximo-reliefapps
Copy link
Contributor

Description

Button action types have been revamped to add different types of actions, when creating a button you will be able to select between these actions:

  • Link: Original action button behavior, you will be able to set a relative direction or external page link to go when clicking the button.
  • Record edition: (Only when having a context DS and record selected) This button will open a modal to edit the selected record.
  • Email notification: To define

Useful links

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Create a button and make sure types are required and the type-specific fields work as expected
  • Use the new button type (edit record) and make sure it works.
  • Use a link type (original function) button and confirm it still works

Screenshots

Check in the frontend ticket: ReliefApplications/ems-frontend#2466

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@Maximo-reliefapps Maximo-reliefapps changed the base branch from main to 2.x.x April 18, 2024 07:39
@Maximo-reliefapps Maximo-reliefapps changed the title Ab#89564 new button action types dashboard AB#89564 new button action types dashboard Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant