Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/AB#91885_Store-GraphQL-schema-in-public-blob-storage-file #1036

Open
wants to merge 3 commits into
base: beta
Choose a base branch
from

Conversation

estelafs
Copy link
Contributor

@estelafs estelafs commented May 3, 2024

Description

Created the uploadSchemaFile file, which is called every time we start the server (re-launches the server with updated schema included) to generate with the new generateAndSaveSchema method the schema file and them upload it to the blob storage.

Useful links

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

As the attached video

Screenshots

video.webm

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@estelafs estelafs added the enhancement Existing feature label May 3, 2024
src/index.ts Outdated Show resolved Hide resolved
@estelafs estelafs marked this pull request as ready for review May 6, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants