Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ab#92502 apply formatting to date fields #1052

Closed
wants to merge 2 commits into from

Conversation

MwanPygmay
Copy link
Contributor

@MwanPygmay MwanPygmay commented May 15, 2024

Description

Add a transformItems method to get the locale string for the date fields. The method can be changed later to support more fields.

Useful links

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

Tried adding a map with a date popup, date has same format as grid

Screenshots

image

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@MwanPygmay MwanPygmay requested a review from a team May 15, 2024 10:33
@MwanPygmay MwanPygmay self-assigned this May 15, 2024
@AntoineRelief AntoineRelief deleted the AB#92502_apply_formatting_to_date_fields branch May 24, 2024 10:48
@AntoineRelief
Copy link
Collaborator

@MwanPygmay

I'm closing this PR
this is a configuration issue, not a code issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants