Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/AB#93130_Allow-query-params-to-be-used-for-REST-widgets-using-reference-data-reusable to multiple ref data types #1058

Merged
merged 3 commits into from
May 20, 2024
Merged

feat/AB#93130_Allow-query-params-to-be-used-for-REST-widgets-using-reference-data-reusable to multiple ref data types #1058

merged 3 commits into from
May 20, 2024

Conversation

estelafs
Copy link
Contributor

@estelafs estelafs commented May 17, 2024 •
edited

Description

Update reference data of type rest methods to include params, adding them to the end of the URL like <main-endpoint>?<query-param1>&<query-param2>&etc

Useful links

Type of change

  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@estelafs estelafs added the enhancement Existing feature label May 17, 2024
@estelafs estelafs self-assigned this May 17, 2024
@estelafs estelafs mentioned this pull request May 17, 2024
Merged
15 tasks
@AntoineRelief AntoineRelief self-requested a review May 20, 2024 08:37
@AntoineRelief AntoineRelief merged commit 506e551 into 2.x.x May 20, 2024
1 check passed
@AntoineRelief AntoineRelief deleted the feat/AB#93130_Allow-query-params-to-be-used-for-REST-widgets-using-reference-data branch May 20, 2024 10:01
AntoineRelief pushed a commit that referenced this pull request May 22, 2024
@semantic-release-bot
chore(release): 2.10.0 [skip ci]
0dac8ea 
# [2.10.0](v2.9.2...v2.10.0) (2024-05-22)

### Bug Fixes

* creation of new users could fail due to duplication errors ([#1059](#1059)) ([95eadbe](95eadbe))

### Features

* REST reference data can also use query params ([#1058](#1058)) ([506e551](506e551))
* use microsoft graph to populate user's attributes ([#1062](#1062)) ([4396301](4396301))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRelief AntoineRelief Awaiting requested review from AntoineRelief

Assignees

@estelafs estelafs

Labels
enhancement Existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@estelafs @AntoineRelief