Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/AB#71363_inconsistency-in-field-permission #792

Open
wants to merge 3 commits into
base: 2.x.x
Choose a base branch
from

Conversation

matheus-relief
Copy link
Collaborator

@matheus-relief matheus-relief commented Oct 26, 2023

Description

This PR changes the editResource mutation so that if we toggle off the a field's canSee permission, it'll automatically remove the canUpdate, if it exists

Useful links

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

See bellow

Screenshots

Peek 2023-08-30 03-01

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@matheus-relief matheus-relief changed the title refactor: remove canUpdate along with canSee for fields fix/AB#71363_inconsistency-in-field-permission Oct 26, 2023
@matheus-relief matheus-relief added the bug Something isn't working label Oct 26, 2023
@matheus-relief matheus-relief self-assigned this Oct 26, 2023
@matheus-relief matheus-relief requested a review from a team October 26, 2023 23:32
@RenzoPrats RenzoPrats self-requested a review October 27, 2023 14:32
Copy link
Contributor

@RenzoPrats RenzoPrats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine,looks good to me!

@NathanHGit NathanHGit changed the base branch from beta to 2.x.x January 29, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants