Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ab#76765 calculated fields not working in aggregation parent form #841

Open
wants to merge 6 commits into
base: 2.x.x
Choose a base branch
from

Conversation

RenzoPrats
Copy link
Contributor

@RenzoPrats RenzoPrats commented Nov 24, 2023

Description

Fixed calculated field not working in an aggregation and layout of parent form.

Useful links

ticket

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

It has been tested creating a form child and then a parent form using the form child as a resource question, after that was created calculated fields in the child resource and finally was created aggregations and layouts of the parent resource using the calculated fields of the child.

Screenshots

Captura de tela de 2023-11-27 12-38-47
Captura de tela de 2023-11-27 12-39-02
Captura de tela de 2023-11-27 12-39-16
Captura de tela de 2023-11-27 12-39-42
Captura de tela de 2023-11-27 12-39-59

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RenzoPrats RenzoPrats marked this pull request as ready for review November 27, 2023 15:42
@RenzoPrats RenzoPrats self-assigned this Nov 27, 2023
@RenzoPrats RenzoPrats requested a review from a team November 27, 2023 15:42
@RenzoPrats RenzoPrats added the bug Something isn't working label Nov 27, 2023
@MwanPygmay MwanPygmay requested review from MwanPygmay and removed request for a team November 28, 2023 10:29
Copy link
Contributor

@MwanPygmay MwanPygmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RenzoPrats, not working, tested with calc field {{calc.if( {{calc.eq( {{data.number}} ; 12 )}} ; 30 ; {{data.number}} )}}.
Screenshot 2023-11-28 at 15 20 48
from above, I think you are missing some steps for unnesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants