Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/AB#80876-add-geographic-context-in-page #856

Open
wants to merge 2 commits into
base: alpha
Choose a base branch
from

Conversation

estelafs
Copy link
Contributor

@estelafs estelafs commented Dec 5, 2023

Description

Update page model and type files with the new geographicContext property. Updated editPage mutation to include updates in the geographicContext and create PageGeographicContextInputType input type

Useful links

Type of change

  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

Edit a page adding/updating the new geographicContext property.

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@estelafs estelafs added the enhancement Existing feature label Dec 5, 2023
@estelafs estelafs requested a review from a team December 5, 2023 20:47
@estelafs estelafs self-assigned this Dec 5, 2023
…end into feat/AB#80876-add-geographic-context-in-page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants