-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/AB#82958-after-duplicating-application-page-refresh-necessary #915
base: 2.x.x
Are you sure you want to change the base?
fix/AB#82958-after-duplicating-application-page-refresh-necessary #915
Conversation
@estelafs |
@AntoineRelief The schema update is triggered here: https://github.com/ReliefApplications/ems-backend/pull/915/files#diff-e4e7a68d82cdfba4e7dab9a32a8f55f3806ffa0cf33f1b8ab64b42941cf68888R86-R105, the resource field permissions update triggers it the because of the calculated fields |
@estelafs |
@AntoineRelief I modified the PR, the schema no longer refreshes in this situation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working fine, looks good to me!
Description
The problem was after duplicating applications with content, the backend would re-launches the server with updated schema because the resource changes require schema update, so the redirection to the new duplicated application didn't happen with the server down. So if you duplicate an empty application, for example, it will open the new application as it should without problems since the backend doesn't reload the server in this case.
Added a new check in the resource calculated fields updates watch that triggered this schema refresh, so when the calculated fields are updated the server will reload as wanted, but not on the calculated fields permissions updates.
Useful links
Type of change
How Has This Been Tested?
Duplicating applications
Screenshots
dup.webm
Checklist:
( * == Mandatory )
More explanation
https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145