Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/AB#80053_remove_pulljob_feature #944

Open
wants to merge 5 commits into
base: 2.x.x
Choose a base branch
from

Conversation

RenzoPrats
Copy link
Contributor

@RenzoPrats RenzoPrats commented Jan 16, 2024

Description

Removed pull job feature.

Useful links

ticket
frontend

Type of change

  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

It has been tested verifying in the app if all features related to pull job feature was removed and if the system continues to working correctly.

Screenshots

Captura de tela de 2024-01-16 12-30-13

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RenzoPrats RenzoPrats requested a review from a team January 16, 2024 15:32
@RenzoPrats RenzoPrats self-assigned this Jan 16, 2024
@RenzoPrats RenzoPrats added enhancement Existing feature refactor Refactor of the code labels Jan 16, 2024
@RenzoPrats RenzoPrats changed the title Feat/ab#80053 remove pulljob feature feat/AB#80053_remove_pulljob_feature Jan 16, 2024
@RenzoPrats RenzoPrats changed the base branch from main to 2.x.x January 16, 2024 15:35
@RenzoPrats RenzoPrats marked this pull request as draft January 16, 2024 15:35
@RenzoPrats RenzoPrats marked this pull request as ready for review January 16, 2024 17:20
@NathanHGit NathanHGit requested review from NathanHGit and removed request for a team January 17, 2024 09:14
Copy link
Contributor

@NathanHGit NathanHGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the frontend, it looks good

@NathanHGit
Copy link
Contributor

I am not familiar with the backend, then I don't know how to fix the following error.
All checks have failed 1 failing check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing feature refactor Refactor of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants